Use PointerValue in UnsafePointerView and UnsafeFnPointer types
fix(ext/ffi): Use PointerValue in UnsafePointerView and UnsafeFnPointer types (#16354)
Use PointerValue in UnsafePointerView and UnsafeFnPointer typesfixuse pointervalue unsafepointerview unsafefnpointer types ext
Committed by aapoalas
commit message
fix(ext/ffi): Use PointerValue in UnsafePointerView and UnsafeFnPointer types (#16354)
There were still remaining bigint usages for pointers. This now finally
fixes all of them, there is only the one `type PointerValue = number |
bigint;` line that references `bigint` in the unstable type definition
file.Editor assessment
Good news first: the body is genuinely informative, explaining that remaining bigint usages existed and pointing to the single PointerValue alias line left in the type definitions. It is wrapped at reasonable width and separated from the header correctly. The header, however, stumbles twice: 'Use' begins capitalized, deviating from the lowercase convention, and the full header runs about 77 characters, exceeding the 72-character truncation point on GitHub. Shortening the description would fix both. The fix type is right, since the mismatch was causing real misbehavior for FFI users working with pointer values.