Flaky test whatsapp_cloud_service_spec.rb:17
fix: flaky test whatsapp_cloud_service_spec.rb:17 (#5786)
Flaky test whatsapp_cloud_service_spec.rb:17fixflaky test whatsapp cloud service spec
Committed by sojan-official
commit message
fix: flaky test whatsapp_cloud_service_spec.rb:17 (#5786)
Fix flaky test: flaky /spec/services/whatsapp/providers/whatsapp_cloud_service_spec.rb:17
example build: https://app.circleci.com/pipelines/github/chatwoot/chatwoot/48955/workflows/a2959d25-19ea-4812-ba15-5aac69c43265/jobs/49523
Cause: factory bot can create phone numbers of length 15 digits, which is valid e164, while our regex only handled up to 14 digitsEditor assessment
This is what a good fix message looks like. The subject names the exact failing spec with file and line, making it grep-able; the body then delivers the complete causal story — an example failing CI build URL, the root cause (factory bot generating 15-digit e164-valid phone numbers while the regex only accepted 14), and the implication. That level of 'why' is directly valuable to maintainers and future readers. If anything, the test type might fit better than fix since the production code and the test's assumptions were reconciled, but fix is common usage. Exemplary.