Ensure modeL_ exists before calling delegate methods
fix: ensure modeL_ exists before calling delegate methods (#20111)
Ensure modeL_ exists before calling delegate methodsfixensure model exists before calling delegate
Committed by MarshallOfSound
commit message
fix: ensure modeL_ exists before calling delegate methods (#20111)
This is a speculative fix for a crash we are seeing in `menuDidClose`. We
can't repro the crash but the traces have it happening in this method
and just by reading through the impl the only part that jumps out as
Might Crash is this `model_` call. Other methods in the menu controller
check `model_` before using it so it probably makes sense to do that here
as well.Editor assessment
The subject states the guard: modeL_ existence is verified before delegate methods run. The body is exemplary: it labels the fix speculative, reports that the menuDidClose crash could not be reproduced, cites the stack traces pointing at this method, reasons that other menu-controller methods already check model_, and concludes the guard probably belongs here. That is honest evidence, reasoning, and confidence level in one paragraph — exactly what a defensive change should document. Hygiene is clean. An exemplar-level message that models careful engineering communication.