Validating buidling a piano project

chore(curriculum): validating buidling a piano project (#46668)
Validating buidling a piano projecta51db1-chore-validating-buidling-a-piano-projectchorevalidating buidling piano project curriculum

Committed by Sboonny

commit message
chore(curriculum): validating buidling a piano project (#46668)

* added lang test and hint
 
* changed seed code to include lang attribute
 
* consistent gamar
 
* allow space between Lang and it's value
 
Co-authored-by: Shaun Hamilton <[email protected]>
 
Co-authored-by: Shaun Hamilton <[email protected]>

Editor assessment

Three problems in one header. 'Validating' is a gerund rather than the imperative 'validate'; 'buidling' is a misspelling of 'building'; and the whole reads like QA exploration rather than a change of record — what was actually committed? If this ships a new curriculum project with lang-attribute tests and hints, as the body suggests, feat or test would describe the work more honestly than chore, and the subject should state what was added, e.g. `feat(curriculum): add piano project with lang attribute checks`. The body's squash bullets ('consistent gamar' — itself a typo for 'grammar') show real content: lang tests, hints, seed code. The scope is right and the Co-authored-by trailer is well-formed. A sloppy header on otherwise substantive work.

Browse categories

More chore examples · Back to search