Send "executionContextDestroyed" notification on program end
feat(core): send "executionContextDestroyed" notification on program end (#16831)
Send "executionContextDestroyed" notification on program endd4f659-feat-send-executioncontextdestroyed-notification-on-program-endfeatsend executioncontextdestroyed notification program end core
Committed by bartlomieju
commit message
feat(core): send "executionContextDestroyed" notification on program end (#16831)
This commit changes "JsRuntime" to send "executionContextDestroyed"
notification when the program finishes and shows a prompt informing
that runtime is waiting for inspector to disconnect.Editor assessment
Well-formed throughout: feat(core) is accurate, the imperative subject names the exact 'executionContextDestroyed' notification and stays under the length limit, and the blank line before the body follows the spec. The body explains what changed — JsRuntime now emits the notification and shows an inspector-wait prompt — but the why is thin: why should the runtime wait for the inspector to disconnect? Also, 'This commit changes...' is redundant narration; commit messages conventionally describe the change directly, e.g. 'JsRuntime now sends...'. A stray trailing space on one wrapped line is a cosmetic nit. Otherwise this is a clear, automation-friendly message that would yield a good changelog entry.