Remove op_http_read

refactor(ext/http): remove op_http_read (#16096)
Remove op_http_readrefactorremove http read ext

Committed by lucacasonato

commit message
refactor(ext/http): remove op_http_read (#16096)

We can use Resource::read_return & op_read instead. This allows HTTP
request bodies to participate in FastStream.
 
To make this work, `readableStreamForRid` required a change to allow non
auto-closing resources to be handled. This required some minor changes
in our FastStream paths in ext/http and ext/flash.

Editor assessment

A high-quality refactor entry. The subject 'remove op_http_read' is short, imperative, and names the exact op; the body then does what refactor bodies should — justify the change ('We can use Resource::read_return & op_read instead'), state the payoff (request bodies joining FastStream), and enumerate the ripple effects through `readableStreamForRid`, ext/http, and ext/flash. Wrapping is consistent and the blank-line separation is spec-correct. One debate: 'allows HTTP request bodies to participate in FastStream' edges toward new capability, so feat would not be absurd, but framed as internal restructuring the refactor label is fair. Commits like this make archaeology pleasant.

Browse categories

More refactor examples · Back to search