Autogenerate vapid keys for push notifications
feat: autogenerate vapid keys for push notifications (#3128)
Autogenerate vapid keys for push notifications6cfd7d-feat-autogenerate-vapid-keys-for-push-notificationsfeatautogenerate vapid keys push notifications
Committed by santhosh-chinnasamy
commit message
feat: autogenerate vapid keys for push notifications (#3128)
* feat: Autogenerate push notification keys
* add vapid service class and remove pushkey model
* add spec for vapid service
* unset vapid env keys
* Unset VAPID_PRIVATE_KEY env variable
Co-authored-by: Sojan Jose <[email protected]>
Co-authored-by: Vishnu Narayanan <[email protected]>Editor assessment
The subject states the feature concretely, vapid keys for push notifications are autogenerated, and feat is right. The body is a change inventory, a vapid service class added, the push key model removed, a spec added, environment keys unset, which records the steps but never explains why keys are now generated instead of configured, the operational problem that motivated the work. No scope, and the Co-authored-by footers are well formed. Hygiene is fine. Understandable and reasonably documented, but the why is absent.